Re: [PATCH] mm/page_alloc: remove the static for local variable node_order

From: Matthew Wilcox
Date: Wed Dec 30 2020 - 07:43:30 EST


On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> local variable node_order do not need the static here.

It bloody well does. It can be up to 2^10 entries on x86 (and larger
on others) That's 4kB which you've now moved onto the stack.

Please, learn more about what you're doing. I suggest sending patches
to drivers/staging; that will help you learn how to submit patches to
linux.