Re: [PATCH v3] regmap: debugfs: Fix a memory leak when calling regmap_attach_dev
From: Greg Kroah-Hartman
Date: Wed Dec 30 2020 - 07:50:00 EST
On Wed, Dec 30, 2020 at 01:01:42PM +0100, Markus Elfring wrote:
> > Thank you very much, very good suggestion,
>
> Thanks for another positive feedback.
>
>
> > do I need to re-send a patch to fix this problem, or modify the previous patch and send it again?
>
> Please convince the involved contributors to integrate a corrected patch version.
>
> * Better indentation.
>
> * …
> >> + if (!map->debugfs_name)
> >> + kfree(map->debugfs_name);
>
> Would this questionable null pointer check result in a memory leak?
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot