Re: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR

From: Bartosz Golaszewski
Date: Sun Jan 03 2021 - 10:30:48 EST


On Fri, Jan 1, 2021 at 6:07 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> > -----Original Message-----
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Sent: 31 December 2020 15:39
> > To: Linus Walleij <linus.walleij@xxxxxxxxxx>; Bartosz Golaszewski
> > <bgolaszewski@xxxxxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Cc: linux-gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> > renesas-soc@xxxxxxxxxxxxxxx; Prabhakar <prabhakar.csengg@xxxxxxxxx>;
> > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Subject: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR
> >
> > The gpio-rcar driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update
> > the description to reflect this.
>
> Not sure we need to make this generic by dropping {1,2,3}/{1,2} and use R-Car and RZ/G SoC's instead ???
>

This looks better IMO - if Geert is OK with that, then let's change it.

Bart

> Regards,
> Biju
>
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> > drivers/gpio/Kconfig | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index
> > c70f46e80a3b..47e545d71df1 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -486,11 +486,12 @@ config GPIO_PXA
> > Say yes here to support the PXA GPIO device
> >
> > config GPIO_RCAR
> > - tristate "Renesas R-Car GPIO"
> > + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} GPIO support"
> > depends on ARCH_RENESAS || COMPILE_TEST
> > select GPIOLIB_IRQCHIP
> > help
> > - Say yes here to support GPIO on Renesas R-Car SoCs.
> > + Say yes here to support GPIO on Renesas R-Car Gen{1,2,3} and
> > + RZ/G{1,2} SoCs.
> >
> > config GPIO_RDA
> > bool "RDA Micro GPIO controller support"
> > --
> > 2.17.1
>