Re: [PATCH 1/1] dt-bindings: adc-keys.txt: clarify description
From: Rob Herring
Date: Sun Jan 03 2021 - 11:38:54 EST
On Tue, 22 Dec 2020 12:08:15 +0100, Heinrich Schuchardt wrote:
> The current description of ADC keys is not precise enough.
>
> "when this key is pressed" leaves it open if a key is considered pressed
> below or above the threshold. This has led to confusion:
> drivers/input/keyboard/adc-keys.c ignores the meaning of thresholds and
> sets the key that is closest to press-threshold-microvolt.
>
> This patch nails down the definitions and provides an interpretation of the
> supplied example.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> ---
> I know that this file needs to be converted to YAML. But lets first get the
> text right.
> ---
> .../devicetree/bindings/input/adc-keys.txt | 22 +++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@xxxxxxxxxx>