Re: [PATCH] regulator: qcom-rpmh: add QCOM_COMMAND_DB dependency

[Bjorn Andersson]

On Wed 30 Dec 08:56 CST 2020, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> A built-in regulator driver cannot link against a modular cmd_db driver:
> 
> qcom-rpmh-regulator.c:(.text+0x174): undefined reference to `cmd_db_read_addr'
> 
> There is already a dependency for RPMh, so add another one of this
> type for cmd_db.
> 
> Fixes: 34c5aa2666db ("regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error")
> Fixes: 46fc033eba42 ("regulator: add QCOM RPMh regulator driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn

> ---
>  drivers/regulator/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 53fa84f4d1e1..5abdd29fb9f3 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
>  config REGULATOR_QCOM_RPMH
>  	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
>  	depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
> +	depends on QCOM_COMMAND_DB || (QCOM_COMMAND_DB=n && COMPILE_TEST)
>  	help
>  	  This driver supports control of PMIC regulators via the RPMh hardware
>  	  block found on Qualcomm Technologies Inc. SoCs.  RPMh regulator
> -- 
> 2.29.2
>