Re: [PATCH] phy: mediatek: allow compile-testing the dsi phy
From: Vinod Koul
Date: Mon Jan 04 2021 - 02:32:12 EST
On 03-01-21, 14:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Randconfig builds show another broken dependency:
>
> WARNING: unmet direct dependencies detected for PHY_MTK_MIPI_DSI
> Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y]
> Selected by [m]:
> - DRM_MEDIATEK [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_MEDIATEK [=n] || ARM [=y] && COMPILE_TEST [=y]) && COMMON_CLK [=y] &&
> HAVE_ARM_SMCCC [=y] && OF [=y] && MTK_MMSYS [=y]
>
> This is similar to the hdmi driver I fixed earlier, and I guess the
> common-clk bug would sooner or later also manifest here, so just use
> the exact same solution I chose for the other driver, and hope that
> any future drivers just copy it from here.
Applied, thanks
>
> Fixes: 90f80d95992f ("phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder")
> Fixes: f5f6e01f9164 ("phy: mediatek: allow compile-testing the hdmi phy")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/phy/mediatek/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> index d38def43b1bf..55f8e6c048ab 100644
> --- a/drivers/phy/mediatek/Kconfig
> +++ b/drivers/phy/mediatek/Kconfig
> @@ -49,7 +49,9 @@ config PHY_MTK_HDMI
>
> config PHY_MTK_MIPI_DSI
> tristate "MediaTek MIPI-DSI Driver"
> - depends on ARCH_MEDIATEK && OF
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> + depends on COMMON_CLK
> + depends on OF
> select GENERIC_PHY
> help
> Support MIPI DSI for Mediatek SoCs.
> --
> 2.29.2
--
~Vinod