Re: [PATCH] extcon: Add stubs for extcon_register_notifier_all() functions

From: Chanwoo Choi
Date: Mon Jan 04 2021 - 05:33:51 EST


Hi Krzysztof,

On Thu, Dec 31, 2020 at 5:56 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> Add stubs for extcon_register_notifier_all() function for !CONFIG_EXTCON
> case. This is useful for compile testing and for drivers which use
> EXTCON but do not require it (therefore do not depend on CONFIG_EXTCON).
>
> Fixes: 815429b39d94 ("extcon: Add new extcon_register_notifier_all() to monitor all external connectors")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> include/linux/extcon.h | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index fd183fb9c20f..0c19010da77f 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -271,6 +271,29 @@ static inline void devm_extcon_unregister_notifier(struct device *dev,
> struct extcon_dev *edev, unsigned int id,
> struct notifier_block *nb) { }
>
> +static inline int extcon_register_notifier_all(struct extcon_dev *edev,
> + struct notifier_block *nb)
> +{
> + return 0;
> +}
> +
> +static inline int extcon_unregister_notifier_all(struct extcon_dev *edev,
> + struct notifier_block *nb)
> +{
> + return 0;
> +}
> +
> +static inline int devm_extcon_register_notifier_all(struct device *dev,
> + struct extcon_dev *edev,
> + struct notifier_block *nb)
> +{
> + return 0;
> +}
> +
> +static inline void devm_extcon_unregister_notifier_all(struct device *dev,
> + struct extcon_dev *edev,
> + struct notifier_block *nb) { }
> +
> static inline struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name)
> {
> return ERR_PTR(-ENODEV);
> --
> 2.25.1
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi