Re: [PATCH v2 13/16] rpmsg: virtio: probe the rpmsg_ctl device

From: Dan Carpenter
Date: Mon Jan 04 2021 - 08:03:41 EST

Next message:
Previous
Messages

Hi Arnaud,

url: If you fix the issue, Reported-by: kernel test Reported-by: Dan Carpenter
smatch warnings:
drivers/rpmsg/virtio_rpmsg_bus.c:978 drivers/rpmsg/virtio_rpmsg_bus.c:979
vim +/vch +978 drivers/rpmsg/v
bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen f7ad26ff952b3ca Stefan Hajnoczi bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen 950a7388f02bf77 Arnaud Pouliquen 532ff49403675dd Arnaud Pouliquen
bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen b1b9891441fa33f Suman Anna 71e4b8bf0482fc7 Michael S. Tsirkin bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen 9b2bbdb22758845 Michael S. Tsirkin bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna f93848f9eeb0f87 Loic Pallardy f93848f9eeb0f87 Loic Pallardy f93848f9eeb0f87 Loic Pallardy b1b9891441fa33f Suman Anna bcabbccabffe732 Ohad Ben-Cohen d999b622fcfb392 Loic Pallardy b1b9891441fa33f Suman Anna b1b9891441fa33f Suman Anna 3119b487e03650b Wei Yongjun 3119b487e03650b Wei Yongjun bcabbccabffe732 Ohad Ben-Cohen 3119b487e03650b Wei Yongjun bcabbccabffe732 Ohad Ben-Cohen de4064af76537f1 Suman Anna 8d95b322ba34b15 Anna, Suman bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen b1b9891441fa33f Suman Anna bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen b1b9891441fa33f Suman Anna bcabbccabffe732 Ohad Ben-Cohen f93848f9eeb0f87 Loic Pallardy bcabbccabffe732 Ohad Ben-Cohen 9dd87c2af651b09 Loic Pallardy bcabbccabffe732 Ohad Ben-Cohen cee51d69a45b6ce Rusty Russell bcabbccabffe732 Ohad Ben-Cohen 57e1a37347d31c6 Rusty Russell bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen 950a7388f02bf77 Arnaud Pouliquen
Not initialized if virtio_has_feature()
950a7388f02bf77 Arnaud Pouliquen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen 950a7388f02bf77 Arnaud Pouliquen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen 532ff49403675dd Arnaud Pouliquen 532ff49403675dd Arnaud Pouliquen 532ff49403675dd Arnaud Pouliquen 532ff49403675dd Arnaud Pouliquen 532ff49403675dd Arnaud Pouliquen 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin bcabbccabffe732 Ohad Ben-Cohen 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin 71e4b8bf0482fc7 Michael S. Tsirkin bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen 950a7388f02bf77 Arnaud Pouliquen
532ff49403675dd Arnaud Pouliquen
d999b622fcfb392 Loic Pallardy eeb0074f36d1ab0 Fernando bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen bcabbccabffe732 Ohad Ben-Cohen
---
0-DAY CI Kernel Test Description: application/gzip Bartosz Golaszewski: "Re: [PATCH v2] gpio: Kconfig: Update help description for GPIO_RCAR config" message: Colin King: "[PATCH][next] cpufreq: powernow-k8: add null check to policy to avoid null pointer dereference" sorted by: [ date ] [ thread ] [ subject ] [ author ] href="https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/introduce-generic-IOCTL-interface-for-RPMsg-channels-management/20201222-190521">https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/introduce-generic-IOCTL-interface-for-RPMsg-channels-management/20201222-190521
href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8653b778e454a7708847aeafe689bce07aeeb94e
(attached as .config)
9.3.0-15) 9.3.0
kindly add following tag as appropriate
robot <lkp@xxxxxxxxx>
<dan.carpenter@xxxxxxxxxx>
rpmsg_probe() error: uninitialized symbol 'vch'.
rpmsg_probe() error: uninitialized symbol 'rpdev_ctrl'.
irtio_rpmsg_bus.c
2011-10-20 846 static int rpmsg_probe(struct virtio_device *vdev)
2011-10-20 847 {
2011-10-20 848 vq_callback_t *vq_cbs[] = { rpmsg_recv_done, rpmsg_xmit_done };
2015-12-17 849 static const char * const names[] = { "input", "output" };
2011-10-20 850 struct virtqueue *vqs[2];
2011-10-20 851 struct virtproc_info *vrp;
2020-11-20 852 struct virtio_rpmsg_channel *vch;
^^^
2020-12-22 853 struct rpmsg_device *rpdev_ns, *rpdev_ctrl;
^^^^^^^^^^
2011-10-20 854 void *bufs_va;
2011-10-20 855 int err = 0, i;
2014-09-16 856 size_t total_buf_space;
2015-03-12 857 bool notify;
2011-10-20 858
2011-10-20 859 vrp = kzalloc(sizeof(*vrp), GFP_KERNEL);
2011-10-20 860 if (!vrp)
2011-10-20 861 return -ENOMEM;
2011-10-20 862
2011-10-20 863 vrp->vdev = vdev;
2011-10-20 864
2011-10-20 865 idr_init(&vrp->endpoints);
2011-10-20 866 mutex_init(&vrp->endpoints_lock);
2011-10-20 867 mutex_init(&vrp->tx_lock);
2011-10-20 868 init_waitqueue_head(&vrp->sendq);
2011-10-20 869
2011-10-20 870 /* We expect two virtqueues, rx and tx (and in this order) */
2017-03-06 871 err = virtio_find_vqs(vdev, 2, vqs, vq_cbs, names, NULL);
2011-10-20 872 if (err)
2011-10-20 873 goto free_vrp;
2011-10-20 874
2011-10-20 875 vrp->rvq = vqs[0];
2011-10-20 876 vrp->svq = vqs[1];
2011-10-20 877
2014-09-16 878 /* we expect symmetric tx/rx vrings */
2014-09-16 879 WARN_ON(virtqueue_get_vring_size(vrp->rvq) !=
2014-09-16 880 virtqueue_get_vring_size(vrp->svq));
2014-09-16 881
2014-09-16 882 /* we need less buffers if vrings are small */
2014-09-16 883 if (virtqueue_get_vring_size(vrp->rvq) < MAX_RPMSG_NUM_BUFS / 2)
2014-09-16 884 vrp->num_bufs = virtqueue_get_vring_size(vrp->rvq) * 2;
2014-09-16 885 else
2014-09-16 886 vrp->num_bufs = MAX_RPMSG_NUM_BUFS;
2014-09-16 887
2017-03-28 888 vrp->buf_size = MAX_RPMSG_BUF_SIZE;
2017-03-28 889
2017-03-28 890 total_buf_space = vrp->num_bufs * vrp->buf_size;
2014-09-16 891
2011-10-20 892 /* allocate coherent memory for the buffers */
2019-01-10 893 bufs_va = dma_alloc_coherent(vdev->dev.parent,
2014-09-16 894 total_buf_space, &vrp->bufs_dma,
2014-09-16 895 GFP_KERNEL);
2013-04-29 896 if (!bufs_va) {
2013-04-29 897 err = -ENOMEM;
2011-10-20 898 goto vqs_del;
2013-04-29 899 }
2011-10-20 900
2018-10-23 901 dev_dbg(&vdev->dev, "buffers: va %pK, dma %pad\n",
2016-08-12 902 bufs_va, &vrp->bufs_dma);
2011-10-20 903
2011-10-20 904 /* half of the buffers is dedicated for RX */
2011-10-20 905 vrp->rbufs = bufs_va;
2011-10-20 906
2011-10-20 907 /* and half is dedicated for TX */
2014-09-16 908 vrp->sbufs = bufs_va + total_buf_space / 2;
2011-10-20 909
2011-10-20 910 /* set up the receive buffers */
2014-09-16 911 for (i = 0; i < vrp->num_bufs / 2; i++) {
2011-10-20 912 struct scatterlist sg;
2017-03-28 913 void *cpu_addr = vrp->rbufs + i * vrp->buf_size;
2011-10-20 914
2017-03-28 915 rpmsg_sg_init(&sg, cpu_addr, vrp->buf_size);
2011-10-20 916
2013-03-20 917 err = virtqueue_add_inbuf(vrp->rvq, &sg, 1, cpu_addr,
2011-10-20 918 GFP_KERNEL);
2012-10-16 919 WARN_ON(err); /* sanity check; this can't really happen */
2011-10-20 920 }
2011-10-20 921
2011-10-20 922 /* suppress "tx-complete" interrupts */
2011-10-20 923 virtqueue_disable_cb(vrp->svq);
2011-10-20 924
2011-10-20 925 vdev->priv = vrp;
2011-10-20 926
2011-10-20 927 /* if supported by the remote processor, enable the name service */
2011-10-20 928 if (virtio_has_feature(vdev, VIRTIO_RPMSG_F_NS)) {
2020-11-20 929 vch = kzalloc(sizeof(*vch), GFP_KERNEL);
is false.
2020-11-20 930 if (!vch) {
2011-10-20 931 err = -ENOMEM;
2011-10-20 932 goto free_coherent;
2011-10-20 933 }
2020-11-20 934
2020-11-20 935 /* Link the channel to our vrp */
2020-11-20 936 vch->vrp = vrp;
2020-11-20 937
2020-11-20 938 /* Assign public information to the rpmsg_device */
2020-11-20 939 rpdev_ns = &vch->rpdev;
2020-11-20 940 rpdev_ns->ops = &virtio_rpmsg_ops;
2020-11-20 941 rpdev_ns->little_endian = virtio_is_little_endian(vrp->vdev);
2020-11-20 942
2020-11-20 943 rpdev_ns->dev.parent = &vrp->vdev->dev;
2020-11-20 944 rpdev_ns->dev.release = virtio_rpmsg_release_device;
2020-11-20 945
2020-11-20 946 err = rpmsg_ns_register_device(rpdev_ns);
2020-11-20 947 if (err)
2020-11-20 948 goto free_coherent;
2011-10-20 949 }
2011-10-20 950
2020-12-22 951 rpdev_ctrl = rpmsg_virtio_add_char_dev(vdev);
2020-12-22 952 if (IS_ERR(rpdev_ctrl)) {
2020-12-22 953 err = PTR_ERR(rpdev_ctrl);
2020-12-22 954 goto free_coherent;
2020-12-22 955 }
2015-03-12 956 /*
2015-03-12 957 * Prepare to kick but don't notify yet - we can't do this before
2015-03-12 958 * device is ready.
2015-03-12 959 */
2015-03-12 960 notify = virtqueue_kick_prepare(vrp->rvq);
2015-03-12 961
2015-03-12 962 /* From this point on, we can notify and get callbacks. */
2015-03-12 963 virtio_device_ready(vdev);
2015-03-12 964
2011-10-20 965 /* tell the remote processor it can start sending messages */
2015-03-12 966 /*
2015-03-12 967 * this might be concurrent with callbacks, but we are only
2015-03-12 968 * doing notify, not a full kick here, so that's ok.
2015-03-12 969 */
2015-03-12 970 if (notify)
2015-03-12 971 virtqueue_notify(vrp->rvq);
2011-10-20 972
2011-10-20 973 dev_info(&vdev->dev, "rpmsg host is online\n");
2011-10-20 974
2011-10-20 975 return 0;
2011-10-20 976
2011-10-20 977 free_coherent:
2020-11-20 @978 kfree(vch);
^^^^^^^^^^^
2020-12-22 @979 kfree(to_virtio_rpmsg_channel(rpdev_ctrl));
^^^^^^^^^^
2019-01-10 980 dma_free_coherent(vdev->dev.parent, total_buf_space,
Guzman Lugo 2012-08-29 981 bufs_va, vrp->bufs_dma);
2011-10-20 982 vqs_del:
2011-10-20 983 vdev->config->del_vqs(vrp->vdev);
2011-10-20 984 free_vrp:
2011-10-20 985 kfree(vrp);
2011-10-20 986 return err;
2011-10-20 987 }
Service, Intel Corporation
://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Bartosz Golaszewski: "Re: [PATCH v2] gpio: Kconfig: Update help description for GPIO_RCAR config"
Previous message: Colin King: "[PATCH][next] cpufreq: powernow-k8: add null check to policy to avoid null pointer dereference"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]