Re: [PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep

From: Bob Peterson
Date: Mon Jan 04 2021 - 12:37:54 EST


----- Original Message -----
> From: Zhaoyang Huang <zhaoyang.huang@xxxxxxxxxx>
>
> As gfs2_quotad_cachep has registered the shrinker, amending
> SLAB_RECLAIM_ACCOUNT when create gfs2_quotad_cachep, which
> make the slab acount to be presiced.
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@xxxxxxxxxx>
> ---
> fs/gfs2/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
> index 136484e..db39de9 100644
> --- a/fs/gfs2/main.c
> +++ b/fs/gfs2/main.c
> @@ -136,7 +136,7 @@ static int __init init_gfs2_fs(void)
>
> gfs2_quotad_cachep = kmem_cache_create("gfs2_quotad",
> sizeof(struct gfs2_quota_data),
> - 0, 0, NULL);
> + 0, SLAB_RECLAIM_ACCOUNT, NULL);
> if (!gfs2_quotad_cachep)
> goto fail_cachep6;
>
> --
> 1.9.1
>
>
Hi,

Thanks for the patch.
We should also do this for gfs2_glock_cachep. Can you add that to your patch?

Regards,

Bob Peterson