Re: [PATCH 1/1] PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device

From: Chanwoo Choi
Date: Mon Jan 04 2021 - 20:05:21 EST


On Tue, Dec 29, 2020 at 12:25 AM pierre kuo <vichy.kuo@xxxxxxxxx> wrote:
>
> Hi myungjoo, kyungmin and cw:
> Would you please help to review this patch?
>
> Thanks a lot.
>
> pierre Kuo <vichy.kuo@xxxxxxxxx> 於 2020年12月16日 週三 上午10:26寫道:
> >
> > In devfreq_add_device, replace devfreq->dev.parent
> > as dev to keep code simple.
> >
> > Signed-off-by: pierre Kuo <vichy.kuo@xxxxxxxxx>
> > ---
> > drivers/devfreq/devfreq.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index 6aa10de792b3..94cc25fd68da 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > @@ -893,13 +893,13 @@ struct devfreq *devfreq_add_device(struct device *dev,
> > goto err_devfreq;
> >
> > devfreq->nb_min.notifier_call = qos_min_notifier_call;
> > - err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_min,
> > + err = dev_pm_qos_add_notifier(dev, &devfreq->nb_min,
> > DEV_PM_QOS_MIN_FREQUENCY);
> > if (err)
> > goto err_devfreq;
> >
> > devfreq->nb_max.notifier_call = qos_max_notifier_call;
> > - err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_max,
> > + err = dev_pm_qos_add_notifier(dev, &devfreq->nb_max,
> > DEV_PM_QOS_MAX_FREQUENCY);
> > if (err)
> > goto err_devfreq;
> > --
> > 2.17.1
> >

Applied it. Thanks.


--
Best Regards,
Chanwoo Choi