Re: [PATCH] ACPI: NFIT: Fix flexible_array.cocci warnings

[Dan Williams]

On Tue, Jan 5, 2021 at 1:28 PM Verma, Vishal L <vishal.l.verma@xxxxxxxxx> wrote:
>
> On Tue, 2021-01-05 at 13:03 -0800, Dan Williams wrote:
> > Julia and 0day report:
> >
> >     Zero-length and one-element arrays are deprecated, see
> >     Documentation/process/deprecated.rst
> >     Flexible-array members should be used instead.
> >
> > However, a straight conversion to flexible arrays yields:
> >
> >     drivers/acpi/nfit/core.c:2276:4: error: flexible array member in a struct with no named members
> >     drivers/acpi/nfit/core.c:2287:4: error: flexible array member in a struct with no named members
> >
> > Instead, just use plain arrays not embedded a flexible arrays.
>
> This reads a bit awkwardly, maybe:
>
>   "Just use plain arrays instead of embedded flexible arrays."

yeah, umm, I left that extra "a" in there as a test... you passed! :)

>
> Other than that, the patch looks looks good:
> Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>

Thanks.