Re: [PATCH 2/2] x86/mm: Remove duplicate definition of _PAGE_PAT_LARGE

[Dave Hansen]

On 1/5/21 1:28 PM, Arvind Sankar wrote:
> diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
> index 394757ee030a..f24d7ef8fffa 100644
> --- a/arch/x86/include/asm/pgtable_types.h
> +++ b/arch/x86/include/asm/pgtable_types.h
> @@ -177,8 +177,6 @@ enum page_cache_mode {
>  #define __pgprot(x)		((pgprot_t) { (x) } )
>  #define __pg(x)			__pgprot(x)
>  
> -#define _PAGE_PAT_LARGE		(_AT(pteval_t, 1) << _PAGE_BIT_PAT_LARGE)

Huh, I didn't realize that duplicate #defines were allowed.  Guess you
learn something new every day.  This looks fine to me, it removes the
exact dup that Ingo appears to have added.

Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>