Re: [PATCH] clocksource: ixp4xx: select TIMER_OF when needed

[Linus Walleij]

On Sun, Jan 3, 2021 at 3:00 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Compile-testing the ixp4xx timer with CONFIG_OF enabled but
> CONFIG_TIMER_OF disabled leads to a harmless warning:
>
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ixp4xx.o' being placed in section `__timer_of_table'
>
> Move the select statement from the platform code into the driver
> so it always gets enabled in configurations that rely on it.
>
> Fixes: 40df14cc5cc0 ("clocksource/drivers/ixp4xx: Add OF initialization support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

That's a nice fix!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij