Re: [PATCH] [v2] net/mlx5e: Fix two double free cases

[Saeed Mahameed]

On Tue, 2021-01-05 at 13:02 -0800, Saeed Mahameed wrote:
> On Mon, 2020-12-28 at 16:48 +0800, Dinghao Liu wrote:
> > mlx5e_create_ttc_table_groups() frees ft->g on failure of
> > kvzalloc(), but such failure will be caught by its caller
> > in mlx5e_create_ttc_table() and ft->g will be freed again
> > in mlx5e_destroy_flow_table(). The same issue also occurs
> > in mlx5e_create_ttc_table_groups(). Set ft->g to NULL after
> > kfree() to avoid double free.
> > 
> > Fixes: 7b3722fa9ef64 ("net/mlx5e: Support RSS for GRE tunneled
                       ^ this is one digit too much..
Fixes line must start with a 12 char SHA and not 13 :).

I fixed this up, no need to do anything but just FYI.

> > packets")
> > Fixes: 33cfaaa8f36ff ("net/mlx5e: Split the main flow steering
> > table")
> > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> > ---
> > 
> > Changelog:
> > 
> > v2: - Set ft->g to NULL after kfree() instead of removing kfree().
> >       Refine commit message.
> > 
> 
> applied to net-next-mlx5,
> Thanks!
>