Re: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in error handling paths

From: David Miller
Date: Tue Jan 05 2021 - 19:01:16 EST


From: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 03 Jan 2021 11:26:26 +1100

> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors().
>
> This is correctly freed in the remove function, but not in the error
> handling path of the probe function. Fix this by adding the missing
> dma_free_coherent() call.
>
> While at it, rename a label in order to be slightly more informative.
>
> Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> Cc: Chris Zankel <chris@xxxxxxxxxx>
> References: commit 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'")
> Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.")
> Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Applied and queued up for -stable, thanks.