Re: [PATCH 3/5] iommu/vt-d: Remove unused dma map/unmap trace events

[Lu Baolu]

Hi Will,

On 2021/1/6 3:04, Will Deacon wrote:
> On Thu, Dec 31, 2020 at 08:53:21AM +0800, Lu Baolu wrote:
> > With commit c588072bba6b5 ("iommu/vt-d: Convert intel iommu driver to
> > the iommu ops"), the trace events for dma map/unmap have no users any
> > more. Remove them so that they don't show up under
> > /sys/kernel/debug/tracing/events/intel_iommu. The users should use the
> > map/unmap traces defined in the iommu core from now on.
> >
> > Fixes: c588072bba6b5 ("iommu/vt-d: Convert intel iommu driver to the iommu ops")
> > Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> > ---
> >   include/trace/events/intel_iommu.h | 119 -----------------------------
> >   1 file changed, 119 deletions(-)
>
> Is this needed in 5.11, or can it wait until 5.12?

It's necessary for 5.11 as far as I can see. Without this, users still
see the events under /sys/kernel/debug/tracing/events/intel_iommu, but
they will get nothing traced even they enable the events.

> Will

Best regards,
baolu