Re: [PATCH v2 02/18] ARM: dts: qcom: sdx55: Add reserved memory nodes

[Manivannan Sadhasivam]

On Tue, Jan 05, 2021 at 09:42:11PM -0600, Bjorn Andersson wrote:
> On Tue 05 Jan 21:07 CST 2021, Manivannan Sadhasivam wrote:
> 
> > On Tue, Jan 05, 2021 at 12:05:49PM -0600, Bjorn Andersson wrote:
> > > On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:
> > > 
> > > > From: Vinod Koul <vkoul@xxxxxxxxxx>
> > > > 
> > > > This adds reserved memory nodes to the SDX55 dtsi as defined by v8 of
> > > > the memory map
> > > > 
> > > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > > > ---
> > > >  arch/arm/boot/dts/qcom-sdx55.dtsi | 67 +++++++++++++++++++++++++++++++
> > > >  1 file changed, 67 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > > index 08b4a40338fa..eeb6bf392f93 100644
> > > > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > > @@ -60,6 +60,73 @@ psci {
> > > >  		method = "smc";
> > > >  	};
> > > >  

[...]

> > > > +		mpss_adsp_mem: memory@90800000 {
> > > > +			no-map;
> > > > +			reg = <0x90800000 0xf800000>;
> > > 
> > > Didn't you say this moved to 0x9c000000?
> > > 
> > 
> > That's for an old bootloader which is used in the MTP. But I guess we should
> > always use the latest mem map for the latest bootloader.
> > 
> 
> That reminds me, a number of times we're learned that these are at least
> related to which firmware the individual vendors are shipping on their
> devices. So the peripheral (remoteproc) regions is better to push out to
> the board file.
> 
> I.e. that would (probably) be &mpss_debug_mem, &ipa_fw_mem and
> &mpss_adsp_mem.
> 

Okay.

Thanks,
Mani

> Regards,
> Bjorn