Re: [PATCH v6 04/18] x86/acrn: Introduce hypercall interfaces

[Shuo A Liu]

On Wed 30.Dec'20 at 18:33:05 +0100, Borislav Petkov wrote:
> On Tue, Dec 01, 2020 at 05:38:39PM +0800, shuo.a.liu@xxxxxxxxx wrote:
> > From: Shuo Liu <shuo.a.liu@xxxxxxxxx>
> >
> > The Service VM communicates with the hypervisor via conventional
> > hypercalls. VMCALL instruction is used to make the hypercalls.
> >
> > ACRN hypercall ABI:
> >   * Hypercall number is in R8 register.
> >   * Up to 2 parameters are in RDI and RSI registers.
> >   * Return value is in RAX register.
> >
> > Introduce the ACRN hypercall interfaces. Because GCC doesn't support R8
> > register as direct register constraints, use supported constraint as
> > input with a explicit MOV to R8 in beginning of asm.
> >
> > Originally-by: Yakui Zhao <yakui.zhao@xxxxxxxxx>
> > Signed-off-by: Shuo Liu <shuo.a.liu@xxxxxxxxx>
> > Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> > Cc: Dave Hansen <dave.hansen@xxxxxxxxx>
> > Cc: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> > Cc: Fengwei Yin <fengwei.yin@xxxxxxxxx>
> > Cc: Zhi Wang <zhi.a.wang@xxxxxxxxx>
> > Cc: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
> > Cc: Yu Wang <yu1.wang@xxxxxxxxx>
> > Cc: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: Arvind Sankar <nivedita@xxxxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> > Cc: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  arch/x86/include/asm/acrn.h | 54 +++++++++++++++++++++++++++++++++++++
> >  1 file changed, 54 insertions(+)
>
> The x86 bits in patches 2-4 look ok now, thanks!
>
> Acked-by: Borislav Petkov <bp@xxxxxxx>

Thanks for review!

Shuo