Re: [PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

[Greg KH]

On Wed, Jan 06, 2021 at 03:36:07PM +0800, Xu Yilun wrote:
> This driver supports the ethernet retimers (C827) for the Intel PAC
> (Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC.
> 
> C827 is an Intel(R) Ethernet serdes transceiver chip that supports
> up to 100G transfer. On Intel PAC N3000 there are 2 C827 chips
> managed by the Intel MAX 10 BMC firmware. They are configured in 4 ports
> 10G/25G retimer mode. Host could query their link states and firmware
> version information via retimer interfaces (Shared registers) on Intel
> MAX 10 BMC. The driver creates sysfs interfaces for users to query these
> information.
> 
> Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> ---
>  .../ABI/testing/sysfs-driver-intel-m10-bmc-retimer |  32 +++++
>  drivers/misc/Kconfig                               |  10 ++
>  drivers/misc/Makefile                              |   1 +
>  drivers/misc/intel-m10-bmc-retimer.c               | 158 +++++++++++++++++++++
>  4 files changed, 201 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-m10-bmc-retimer
>  create mode 100644 drivers/misc/intel-m10-bmc-retimer.c
> 
> diff --git a/Documentation/ABI/testing/sysfs-driver-intel-m10-bmc-retimer b/Documentation/ABI/testing/sysfs-driver-intel-m10-bmc-retimer
> new file mode 100644
> index 0000000..528712a
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-driver-intel-m10-bmc-retimer
> @@ -0,0 +1,32 @@
> +What:		/sys/bus/platform/devices/n3000bmc-retimer.*.auto/tag
> +Date:		Jan 2021
> +KernelVersion:	5.12
> +Contact:	Xu Yilun <yilun.xu@xxxxxxxxx>
> +Description:	Read only. Returns the tag of the retimer chip. Now there are 2
> +		retimer chips on Intel PAC N3000, they are tagged as
> +		'retimer_A' and 'retimer_B'.
> +		Format: "retimer_%c".
> +
> +What:		/sys/bus/platform/devices/n3000bmc-retimer.*.auto/sbus_version
> +Date:		Jan 2021
> +KernelVersion:	5.12
> +Contact:	Xu Yilun <yilun.xu@xxxxxxxxx>
> +Description:	Read only. Returns the Transceiver bus firmware version of
> +		the retimer chip.
> +		Format: "0x%04x".
> +
> +What:		/sys/bus/platform/devices/n3000bmc-retimer.*.auto/serdes_version
> +Date:		Jan 2021
> +KernelVersion:	5.12
> +Contact:	Xu Yilun <yilun.xu@xxxxxxxxx>
> +Description:	Read only. Returns the SERDES firmware version of the retimer
> +		chip.
> +		Format: "0x%04x".
> +
> +What:		/sys/bus/platform/devices/n3000bmc-retimer.*.auto/link_statusX
> +Date:		Jan 2021
> +KernelVersion:	5.12
> +Contact:	Xu Yilun <yilun.xu@xxxxxxxxx>
> +Description:	Read only. Returns the status of each line side link. "1" for
> +		link up, "0" for link down.
> +		Format: "%u".

Who is going to use all of these read-only attributes?

And why isn't this information exported in the "normal" way for network
devices?  Having them as custom sysfs attributes ensures that no
existing tools will work with these at all, right?  Why not do the
standard thing here isntead?

thanks,

greg k-h