Re: [PATCH -next] mtd: use resource_size

From: Miquel Raynal
Date: Wed Jan 06 2021 - 09:50:41 EST


Hello,

Zheng Yongjun <zhengyongjun3@xxxxxxxxxx> wrote on Wed, 6 Jan 2021
21:18:31 +0800:

> Use resource_size rather than a verbose computation on
> the end and start fields.

The commit message and the patch content do not match.

>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
> ---
> drivers/mtd/maps/pci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/maps/pci.c b/drivers/mtd/maps/pci.c
> index 377ef0fc4e3e..ca00d211e73e 100644
> --- a/drivers/mtd/maps/pci.c
> +++ b/drivers/mtd/maps/pci.c
> @@ -90,8 +90,8 @@ intel_iq80310_init(struct pci_dev *dev, struct map_pci_info *map)
> u32 win_base;
>
> map->map.bankwidth = 1;
> - map->map.read = mtd_pci_read8,
> - map->map.write = mtd_pci_write8,
> + map->map.read = mtd_pci_read8;
> + map->map.write = mtd_pci_write8;
>
> map->map.size = 0x00800000;
> map->base = ioremap(pci_resource_start(dev, 0),
> @@ -185,8 +185,8 @@ intel_dc21285_init(struct pci_dev *dev, struct map_pci_info *map)
> return -ENXIO;
>
> map->map.bankwidth = 4;
> - map->map.read = mtd_pci_read32,
> - map->map.write = mtd_pci_write32,
> + map->map.read = mtd_pci_read32;
> + map->map.write = mtd_pci_write32;
> map->map.size = len;
> map->base = ioremap(base, len);
>

Thanks,
Miquèl