Re: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support fallback

[Maxime Ripard]

Hi!

Thanks for your patch

The prefix in your commit title should be ARM: dts: sun5i

It looks like your patch has been wrapped. Make sure you send it through
git send-email, or at least that your mailer don't mangle it.

On Wed, Dec 23, 2020 at 08:58:15PM +0100, Sergio Sota wrote:
> From d5fcc1d4aec82ffe6de78cc40a6f53910e2e88ba Mon Sep 17 00:00:00 2001
> From: Sergio Sota <pikaslabs@xxxxxxxxx>
> Date: Wed, 23 Dec 2020 20:03:55 +0100
> Subject: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support
>  fallback
> 
> The A10s/A13 display frontend driver is not implemented
> The A10 has a compatible display frontend driver

You should expand a bit on this one. At the DT level, compatible means
that the entire A13 controller can be driven just like the one found on
the A10, for every feature (including the ones we don't support).

Given that the documentation for it is sparse on the A10, I'm assuming
that you instead tested the current driver and found that it was working
for you. However, it doesn't mean that it's the case for each feature
supported by the controller and thus we can't really make that claim.

We should instead add the support for the A13 compatible in the driver.

Maxime

Attachment: signature.asc
Description: PGP signature