Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

[Andrew Morton]

On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He <bhe@xxxxxxxxxx> wrote:

> > --- 5.11-rc2/include/linux/memcontrol.h	2020-12-27 20:39:36.751923135 -0800
> > +++ linux/include/linux/memcontrol.h	2021-01-03 19:38:24.822978559 -0800
> > @@ -665,7 +665,7 @@ static inline struct lruvec *mem_cgroup_
> >  {
> >  	struct mem_cgroup *memcg = page_memcg(page);
> >  
> > -	VM_WARN_ON_ONCE_PAGE(!memcg, page);
> > +	VM_WARN_ON_ONCE_PAGE(!memcg && !mem_cgroup_disabled(), page);
> >  	return mem_cgroup_lruvec(memcg, pgdat);
> 
> Thanks for fixing this. We also encountered this issue in kdump kernel
> with the mainline 5.10 kernel since 'cgroup_disable=memory' is added.

Thanks - I added the cc:stable.