Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

[Michael Walle]

Hi Shawn,

Am 2021-01-07 07:40, schrieb Shawn Guo:
> On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
> > The offset of the reset request register is 0, the absolute address is
> > 0x1e60000. Boards without PSCI support will fail to perform a reset:
> >
> > [   26.734700] reboot: Restarting system
> > [   27.743259] Unable to restart system
> > [   27.746845] Reboot failed -- System halted
> >
> > Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> > Signed-off-by: Michael Walle <michael@xxxxxxxx>
>
> Out of curiosity, how did you get it fixed with your commit 
> 3f0fb37b22b4
> ("arm64: dts: ls1028a: fix reboot node") in the first place?

I simply must have missed it. There is also a fallback reset method
via the watchdog in the chain, which kicks in if this wasn't successful.
So if you test it, it is easy to think its working although its not.

-michael