Re: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

From: dinghao . liu
Date: Thu Jan 07 2021 - 02:55:48 EST


> On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao.liu@xxxxxxxxxx
> wrote:
> > > I used this one for a test:
> > >
> > > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bugfix@xxxxxxxxxxxxxxxxx/
> > >
> > > I'm not getting the Fixes tag when I download the mbox.
> >
> > It seems that automatically generating Fixes tags is a hard work.
> > Both patches and bugs could be complex. Sometimes even human cannot
> > determine which commit introduced a target bug.
> >
> > Is this an already implemented functionality?
>
> I'm not sure I understand. Indeed finding the right commit to use in
> a Fixes tag is not always easy, and definitely not easy to automate.
> Human validation is always required.
>
> If we could easily automate finding the commit which introduced a
> problem we wouldn't need to add the explicit tag, backporters could
> just run such script locally.. That's why it's best if the author
> does the digging and provides the right tag.
>
> The conversation with Konstantin and Florian was about automatically
> picking up Fixes tags from the mailing list by the patchwork software,
> when such tags are posted in reply to the original posting, just like
> review tags. But the tags are still generated by humans.

It's clear to me, thanks.

Regards,
Dinghao