Re: [PATCH v2] x86: fix movdir64b() sparse warning

From: Borislav Petkov
Date: Thu Jan 07 2021 - 02:56:36 EST


On Wed, Jan 06, 2021 at 03:40:25PM -0700, Dave Jiang wrote:

> Subject: Re: [PATCH v2] x86: fix movdir64b() sparse warning

There are a lot of times I don't agree with checkpatch but this time I do:

WARNING: A patch subject line should describe the change not the tool that found it
#2:
Subject: [PATCH v2] x86: fix movdir64b() sparse warning

Pls fix your other patch subject too.

> Add missing __iomem annotation to address sparse warning. Caller is expected
> to pass an __iomem annotated pointer to this function. The current usages
> send a 64bytes command descriptor to an MMIO location (portal) on a
> device for consumption. When future usages for MOVDIR64B instruction show
> up in kernel for memory to memory operation is needed, we can revisit.

Who's "we"?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette