Re: [PATCH] mtd: spi-nor: winbond: Add support for w25q512jv

[Shuhao Mai]

On Mon, Jan 04, 2021 at 08:58:26AM +0000, Tudor.Ambarus@xxxxxxxxxxxxx wrote:
> Hi, Shuhao,
> 
> On 11/11/20 3:45 AM, Shuhao Mai wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > Add support for w25q512jv. This is of the same series chip with
> > w25q256jv, which is already supported, but with size doubled and
> > different JEDEC ID.
> 
> Where and how was this tested? Please add this info in the commit
> message.
>

Will add it in next version.

> > 
> > Signed-off-by: Shuhao Mai <shuhao.mai.1990@xxxxxxxxx>
> > ---
> >  drivers/mtd/spi-nor/winbond.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> > index e5dfa786f190..beaa6389e2dc 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
> >                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> >                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> > +       { "w25q512jv", INFO(0xef4020, 0, 64 * 1024, 1024,
> 
> We should name it "w25q512jvq" in order to differentiate it to the
> "M" version: https://www.winbond.com/resource-files/W25Q512JV%20DTR%20RevD%2006292020%20133.pdf
> 
> The flash supports BP locking and we can enable it if you can test 
> the locking with mtd-utils. Not mandatory though.
> 
> Cheers,
> ta

I tried flash lock on my test enviorment, but it doesn't work. I think I'll
only update the flash name in next version, and submit a new patch when I
have answer to it.

Best,
Shuhao

> > +                           SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> >  };
> > 
> >  /**
> > --
> > 2.20.1
> > 
>