Re: [PATCH] software_node: Add kernel-doc comments to exported symbols

[Daniel Scally]

Hi Heikki

On 07/01/2021 14:19, Heikki Krogerus wrote:
> On Tue, Jan 05, 2021 at 03:39:42PM +0000, Daniel Scally wrote:
>> Hi Andy
>>
>> On 05/01/2021 14:53, Andy Shevchenko wrote:
>>> On Mon, Jan 04, 2021 at 11:47:36PM +0000, Daniel Scally wrote:
>>>> A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any
>>>> kernel-doc comments; add those in so all exported symbols are documented.
>>> Thanks, it's helpful!
>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>>> after addressing few nitpicks
>> Thanks for reviewing
>>>> Signed-off-by: Daniel Scally <djrscally@xxxxxxxxx>
>>>> ---
>>>> With a view to maybe writing some documentation once the fwnode_graph_*()
>>>> functions are also added.
>>> FWIW, Heikki used to have a draft patch of swnode documentation, not sure
>>> what's the current status of it.
>> Oh cool ok; I'll defer to him then.
> I actually had a similar patch prepared as part of the series adding
> the documentation for software nodes, but your comments are better
> than mine. So, after you have addressed Andy's comments:
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Great, thanks - and for the other R-bs just now also. I'll send a v2 of
this one tonight/tomorrow (depends how much else I get through)