Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

[Barnabás Pőcze]

Hi


2021. január 7., csütörtök 0:43 keltezéssel, Hans de Goede írta:

> Hi Perry,
>
> On 12/28/20 2:28 PM, Perry Yuan wrote:
>
> > From: Perry Yuan perry_yuan@xxxxxxxx
> > add support for dell privacy driver for the dell units equipped
> > hardware privacy design, which protect users privacy
> > of audio and camera from hardware level. once the audio or camera
> > privacy mode enabled, any applications will not get any audio or
> > video stream.
> > when user pressed ctrl+F4 hotkey, audio privacy mode will be
> > enabled,Micmute led will be also changed accordingly.
> > The micmute led is fully controlled by hardware & EC.
> > and camera mute hotkey is ctrl+F9.currently design only emmit
> > SW_CAMERA_LENS_COVER event while the camera LENS shutter will be
> > changed by EC & HW control.
> > *The flow is like this:
> >
> > 1.  User presses key. HW does stuff with this key (timeout is started)
> > 2.  Event is emitted from FW
> > 3.  Event received by dell-privacy
> > 4.  KEY_MICMUTE emitted from dell-privacy
> > 5.  Userland picks up key and modifies kcontrol for SW mute
> > 6.  Codec kernel driver catches and calls ledtrig_audio_set, like this:
> >     ledtrig_audio_set(LED_AUDIO_MICMUTE,
> >     rt715->micmute_led ? LED_ON :LED_OFF);
> >
> > 7.  If "LED" is set to on dell-privacy notifies ec,
> >     and timeout is cancelled,HW mic mute activated.
> >
> >
> > Signed-off-by: Perry Yuan perry_yuan@xxxxxxxx
> > Signed-off-by: Limonciello Mario mario_limonciello@xxxxxxxx
>
> Thank you for your patch, please send a new version addressing
> Barnabás' review comment and including the second patch of the
> series.
> [...]

I think first something needs to be figured out regarding
the integration with the rest of the Dell modules. I feel
that list is not a desirable way to do it.


Regards,
Barnabás Pőcze