Re: [PATCH] x86/resctrl: add printf attribute to log function

[Reinette Chatre]

Hi Tom,

On 12/21/2020 8:00 AM, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> Attributing the function allows the compiler to more thoroughly
> check the use of the function with -Wformat and similar flags.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
>   arch/x86/kernel/cpu/resctrl/internal.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..c4d320d02fd5 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {
>   
>   void rdt_last_cmd_clear(void);
>   void rdt_last_cmd_puts(const char *s);
> +__printf(1, 2)
>   void rdt_last_cmd_printf(const char *fmt, ...);
>   
>   void rdt_ctrl_update(void *arg);

This is a valuable addition, thank you.

Acked-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette