Re: [PATCH v2] driver core: Fix device link device name collision

From: Michael Walle
Date: Thu Jan 07 2021 - 19:28:37 EST


Am 2021-01-08 01:14, schrieb Michael Walle:
Am 2021-01-08 00:41, schrieb Saravana Kannan:
The device link device's name was of the form:
<supplier-dev-name>--<consumer-dev-name>

This can cause name collision as reported here [1] as device names are
not globally unique. Since device names have to be unique within the
bus/class, add the bus/class name as a prefix to the device names used to
construct the device link device name.

So the devuce link device's name will be of the form:
<supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name>:<consumer-dev-name>

[1] - https://lore.kernel.org/lkml/20201229033440.32142-1-michael@xxxxxxxx/

Cc: stable@xxxxxxxxxxxxxxx
Fixes: 287905e68dd2 ("driver core: Expose device link details in sysfs")
Reported-by: Michael Walle <michael@xxxxxxxx>
Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
---

This makes it even worse.

Mhh, actually there are now other errors (the ones before might be fixed). Seems
to be truncated filenames and for the iommu ones, I don't know.

--
-michael