Re: [PATCH] spi: cadence-quadspi: Fix build warning on 32-bit platforms
From: Mark Brown
Date: Mon Jan 11 2021 - 11:30:49 EST
On Fri, 8 Jan 2021 23:44:57 +0530, Pratyush Yadav wrote:
> The kernel test robot reports the following warning.
>
> drivers/spi/spi-cadence-quadspi.c:966:24: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'unsigned int *') and 'typeof (500UL) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
> msecs_to_jiffies(max(len, 500UL)))) {
> ^~~~~~~~~~~~~~~
> include/linux/minmax.h:58:19: note: expanded from macro 'max'
> #define max(x, y) __careful_cmp(x, y, >)
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/minmax.h:42:24: note: expanded from macro '__careful_cmp'
> __builtin_choose_expr(__safe_cmp(x, y), \
> ^~~~~~~~~~~~~~~~
> include/linux/minmax.h:32:4: note: expanded from macro '__safe_cmp'
> (__typecheck(x, y) && __no_side_effects(x, y))
> ^~~~~~~~~~~~~~~~~
> include/linux/minmax.h:18:28: note: expanded from macro '__typecheck'
> (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
> 1 warning generated.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: cadence-quadspi: Fix build warning on 32-bit platforms
commit: 2ef0170e90391f1adb31c449059b8efdc923707c
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark