Re: Re: [PATCH] block: Fix an error handling in add_partition
From: dinghao . liu
Date: Sat Jan 16 2021 - 06:09:43 EST
> On 1/15/21 11:34 PM, Dinghao Liu wrote:
> > Once we have called device_initialize(), we should
> > use put_device() to give up the reference on error,
> > just like what we have done on failure of device_add().
> > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> Please consider having following commit message, since above
> commit message is looking odd from what we have in the tree :-
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
Thanks for this suggestion!
> Also have you tested this patch with the with generating appropriate error ?
No, this problem is found through comparing existing source code.