Re: [PATCH v6 3/3] iio: dac: ad5766: add driver support for AD5766

From: Jonathan Cameron
Date: Sat Jan 16 2021 - 12:37:53 EST


On Fri, 15 Jan 2021 13:21:05 +0200
Cristian Pop <cristian.pop@xxxxxxxxxx> wrote:

> The AD5766/AD5767 are 16-channel, 16-bit/12-bit, voltage output dense DACs
> Digital-to-Analog converters.
>
> This change adds support for these DACs.
>
> Signed-off-by: Cristian Pop <cristian.pop@xxxxxxxxxx>

I spoke too soon. Please run a W=1 build for future cases. It tends
to pick up on little issues - in this case a plural vs singular
in the docs vs the code.

...
> +/**
> + * struct ad5766_chip_info - chip specific information
> + * @num_channels: number of channels
> + * @channel: channel specification
channels.

Fixed up and pushed out.

thanks,

Jonathan


> + */
> +struct ad5766_chip_info {
> + unsigned int num_channels;
> + const struct iio_chan_spec *channels;
> +};