RE: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings

From: Martin Blumenstingl
Date: Sat Jan 16 2021 - 15:30:11 EST

(sorry for only seeing this late)

> +maintainers:
> + - John Crispin <john@xxxxxxxxxxx>
personally I think we should get at least John's Acked-by but I don't
know if there's any rule for adding a dt-binding for some other

> +required:
> + - compatible
> + - reg
based on "DOs and DON’Ts for designing and writing Devicetree bindings"
from [0] I think this is incomplete
As far as I know CGU contains some PLLs. These PLLs need at least one
input: the main XTAL which is found on the board

Also the Lantiq code does not use the common clock framework yet. Once
that's used we also need #clock-cells = <1>. I don't know if that
should be added already (or not).

> +examples:
> + - |
> + cgu@103000 {
this should be clock-controller@...

Best regards,