Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset

From: Shawn Guo
Date: Mon Jan 18 2021 - 01:33:53 EST


On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote:
> RTC pcf2127 device driver has changed default behaviour of the watchdog
> feature in v5.11-rc1. Now you need to explicitly enable it with a
> device tree property, "reset-source", when used in the board design.

It sound that the existing DTBs are broken by this default behaviour
change?

>
> Fixes: 71ac13457d9d ("rtc: pcf2127: only use watchdog when explicitly available")
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@xxxxxxxxx>
> Cc: Bruno Thomsen <bth@xxxxxxxxxxxx>
> Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

Applied, thanks.

Shawn

> ---
> arch/arm/boot/dts/imx7d-flex-concentrator.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx7d-flex-concentrator.dts b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> index 84b095279e65..bd6b5285aa8d 100644
> --- a/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> +++ b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> @@ -115,6 +115,7 @@ pcf2127: rtc@0 {
> compatible = "nxp,pcf2127";
> reg = <0>;
> spi-max-frequency = <2000000>;
> + reset-source;
> };
> };
>
>
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> --
> 2.29.2
>