Re: [PATCH RFC 2/3] media: i2c: adv7842: remove open coded version of SMBus block read

From: Wolfram Sang
Date: Mon Jan 18 2021 - 04:47:36 EST

Hello Hans,

I hope you are well!

> > The open coded version differs from the one in the core in one way: the
> > buffer will be always copied back, even when the transfer failed. It
> > looks like it is expected that the sanity check for a correct CRC and
> > header will bail out later.
> Nah, it's just a bug. It should have returned and checked the error code,
> so your patch does the right thing.

I see. So, I will only update the commit message.

Thanks for the reviews!

All the best,


Attachment: signature.asc
Description: PGP signature