Re: [PATCH v7 1/4] pinctrl: qcom: Allow SoCs to specify a GPIO function that's not 0

From: Linus Walleij
Date: Mon Jan 18 2021 - 13:19:46 EST


On Fri, Jan 15, 2021 at 4:16 AM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:

> There's currently a comment in the code saying function 0 is GPIO.
> Instead of hardcoding it, let's add a member where an SoC can specify
> it. No known SoCs use a number other than 0, but this just makes the
> code clearer. NOTE: no SoC code needs to be updated since we can rely
> on zero-initialization.
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Reviewed-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> Tested-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Patches applied for fixes!

Yours,
Linus Walleij