[PATCH net v2 0/2] sh_eth: Fix reboot crash

From: Geert Uytterhoeven
Date: Mon Jan 18 2021 - 13:21:15 EST


This patch fixes a regression v5.11-rc1, where rebooting while a sh_eth
device is not opened will cause a crash.

Changes compared to v1:
- Export mdiobb_{read,write}(),
- Call mdiobb_{read,write}() now they are exported,
- Use mii_bus.parent to avoid bb_info.dev copy,
- Drop RFC state.

Alternatively, mdio-bitbang could provide Runtime PM-aware wrappers
itself, and use them either manually (through a new parameter to
alloc_mdio_bitbang(), or a new alloc_mdio_bitbang_*() function), or
automatically (e.g. if pm_runtime_enabled() returns true). Note that
the latter requires a "struct device *" parameter to operate on.
Currently there are only two drivers that call alloc_mdio_bitbang() and
use Runtime PM: the Renesas sh_eth and ravb drivers. This series fixes
the former, while the latter is not affected (it keeps the device
powered all the time between driver probe and driver unbind, and
changing that seems to be non-trivial).

Thanks for your comments!

Geert Uytterhoeven (2):
net: mdio-bitbang: Export mdiobb_{read,write}()
sh_eth: Make PHY access aware of Runtime PM to fix reboot crash

drivers/net/ethernet/renesas/sh_eth.c | 26 ++++++++++++++++++++++++++
drivers/net/mdio/mdio-bitbang.c | 6 ++++--
include/linux/mdio-bitbang.h | 3 +++
3 files changed, 33 insertions(+), 2 deletions(-)




Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds