Re: [PATCH v2 4/7] i2c: i2c-core-acpi: Add i2c_acpi_dev_name()
From: Joe Perches
Date: Mon Jan 18 2021 - 13:48:00 EST
On Mon, 2021-01-18 at 15:39 +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2021 at 12:34:25AM +0000, Daniel Scally wrote:
> > We want to refer to an i2c device by name before it has been
Andy, are you next going to suggest renaming all the files with i2c?
$ git ls-files | grep i2c | wc -l
Please do not use the pedantic I²C, 7 bit ascii is just fine here.
My keyboard does not have a superscripted 2 key, and yes, I know
how to use it with multiple keypresses but it's irrelevant.
> > created by the kernel; add a function that constructs the name
> > from the acpi device instead.
> acpi -> ACPI
Same deal with acpi filenames. Everyone already recognizes acpi is
actually ACPI and there isn't any confusion in anyone's mind.
$ git ls-files | grep acpi | wc -l
> Prefix: "i2c: core: "
Please stop being a pedant on these trivial things.
It's unimportant and has almost no value.