Re: [PATCH] sh: check return code of request_irq
From: John Paul Adrian Glaubitz
Date: Mon Jan 18 2021 - 14:03:38 EST
On 1/1/21 9:42 PM, Miguel Ojeda wrote:
> On Fri, Jan 1, 2021 at 2:50 PM John Paul Adrian Glaubitz
> <glaubitz@xxxxxxxxxxxxxxxxxxx> wrote:
>> Verified on my SH-7785LCR board. Boots fine.
>> Tested-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> Thanks for testing, John!
> I think Masahiro was concerned about the error case (I assume you
> tested the happy path).
Not sure about testing the error case though. How do I make request_irq()
> In any case, if no maintainer suggests something else, looks good to
> me (and it is no worse than the status quo unless the `pr_err()` can
> somehow kill it), so:
> Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@xxxxxxxxxx
`. `' Freie Universitaet Berlin - glaubitz@xxxxxxxxxxxxxxxxxxx
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913