Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps
From: Timur Tabi
Date: Mon Jan 18 2021 - 14:06:16 EST
On 1/18/21 12:26 PM, Matthew Wilcox wrote:
Don't make it easy. And don't make it look like they're doing
something innocent. DUMP_PREFIX_SECURITY_HOLE would be OK
by me. DUMP_PREFIX_LEAK_INFORMATION would work fine too.
DUMP_PREFIX_MAKE_ATTACKERS_LIFE_EASY might be a bit too far.
It's already extremely easy to replace %p with %px in your own printks,
so I don't really understand your argument.
Seriously, this patch should not be so contentious. If you want hashed
addresses, then nothing changes. If you need unhashed addresses while
debugging, then use DUMP_PREFIX_UNHASHED. Just like you can use %px in
printk. I never use %p in my printks, but then I never submit code
upstream that prints addresses, hashed or unhashed.