Re: [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs

[David Hildenbrand]

On 16.01.21 10:18, Miaohe Lin wrote:
> Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
> sizes"), we can use macro default_hstate to get the struct hstate which
> we use by default. But init_hugetlbfs_fs() forgot to use it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> ---
>  fs/hugetlbfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 9b221b87fbea..88751e35e69d 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1544,7 +1544,7 @@ static int __init init_hugetlbfs_fs(void)
>  		goto out_free;
>  
>  	/* default hstate mount is required */
> -	mnt = mount_one_hugetlbfs(&hstates[default_hstate_idx]);
> +	mnt = mount_one_hugetlbfs(&default_hstate);
>  	if (IS_ERR(mnt)) {
>  		error = PTR_ERR(mnt);
>  		goto out_unreg;
> 

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

-- 
Thanks,

David / dhildenb