Re: hwmon: (nct6683) Support ASRock boards.
From: Guenter Roeck
Date: Tue Jan 19 2021 - 01:03:59 EST
On 1/18/21 9:15 PM, Blaž Hrastnik wrote:
> (cc-ing David Bartley, who wrote the MSI patch)
> I had a follow-up question: I noticed that support for MSI was added in
> December, but there's this conditional that wasn't changed:
> /* Only update pwm values for Mitac boards */
> if (data->customer_id == NCT6683_CUSTOMER_ID_MITAC)
> return attr->mode | S_IWUSR;
> Should this continue to only apply for Mitac boards, or should it be changed to
> != NCT6683_CUSTOMER_ID_INTEL?
No, this has to be tested explicitly for each vendor.