drivers/net/wireless/intel/iwlegacy/4965-mac.c:2822 il4965_hdl_tx() error: uninitialized symbol 'tid'.

From: Dan Carpenter
Date: Tue Jan 19 2021 - 04:08:54 EST

tree: .config.gzDescription: application/gzip Paul Kocialkowski: "Re: [PATCH 1/2] of: device: Allow DMA range map to be set before of_dma_configure_id" Auger Eric: "Re: [PATCH RFC v1 00/15] iommu/virtio: Nested stage support with Arm" date ] [ thread ] [ subject ] [ author ] ub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
treewide: Remove uninitialized_var() usage
as .config)
appropriate
t;
il4965_hdl_tx() error: uninitialized symbol 'tid'.
mac.c
Stanislaw Gruszka 2012-02-13 2759 static void
Stanislaw Gruszka 2012-02-13 2760 il4965_hdl_tx(struct il_priv *il, struct il_rx_buf *rxb)
Stanislaw Gruszka 2012-02-13 2761 {
Stanislaw Gruszka 2012-02-13 2762 struct il_rx_pkt *pkt = rxb_addr(rxb);
Stanislaw Gruszka 2012-02-13 2763 u16 sequence = le16_to_cpu(pkt->hdr.sequence);
Stanislaw Gruszka 2012-02-13 2764 int txq_id = SEQ_TO_QUEUE(sequence);
Stanislaw Gruszka 2012-02-13 2765 int idx = SEQ_TO_IDX(sequence);
Stanislaw Gruszka 2012-02-13 2766 struct il_tx_queue *txq = &il->txq[txq_id];
Stanislaw Gruszka 2012-02-13 2767 struct sk_buff *skb;
Stanislaw Gruszka 2012-02-13 2768 struct ieee80211_hdr *hdr;
Stanislaw Gruszka 2012-02-13 2769 struct ieee80211_tx_info *info;
Stanislaw Gruszka 2012-02-13 2770 struct il4965_tx_resp *tx_resp = (void *)&pkt->u.raw[0];
Stanislaw Gruszka 2012-02-13 2771 u32 status = le32_to_cpu(tx_resp->u.status);
Kees Cook 2020-06-03 2772 int tid;
^^^^^^^
Stanislaw Gruszka 2012-02-13 2773 int sta_id;
Stanislaw Gruszka 2012-02-13 2774 int freed;
Stanislaw Gruszka 2012-02-13 2775 u8 *qc = NULL;
Stanislaw Gruszka 2012-02-13 2776 unsigned long flags;
Stanislaw Gruszka 2012-02-13 2777
Stanislaw Gruszka 2012-02-13 2778 if (idx >= txq->q.n_bd || il_queue_used(&txq->q, idx) == 0) {
Stanislaw Gruszka 2012-02-13 2779 IL_ERR("Read idx for DMA queue txq_id (%d) idx %d "
Stanislaw Gruszka 2012-02-13 2780 "is out of range [0-%d] %d %d\n", txq_id, idx,
Stanislaw Gruszka 2012-02-13 2781 txq->q.n_bd, txq->q.write_ptr, txq->q.read_ptr);
Stanislaw Gruszka 2012-02-13 2782 return;
Stanislaw Gruszka 2012-02-13 2783 }
Stanislaw Gruszka 2012-02-13 2784
Stanislaw Gruszka 2012-02-13 2785 txq->time_stamp = jiffies;
Stanislaw Gruszka 2012-02-13 2786
Stanislaw Gruszka 2012-02-13 2787 skb = txq->skbs[txq->q.read_ptr];
Stanislaw Gruszka 2012-02-13 2788 info = IEEE80211_SKB_CB(skb);
Stanislaw Gruszka 2012-02-13 2789 memset(&info->status, 0, sizeof(info->status));
Stanislaw Gruszka 2012-02-13 2790
Stanislaw Gruszka 2012-02-13 2791 hdr = (struct ieee80211_hdr *) skb->data;
Stanislaw Gruszka 2012-02-13 2792 if (ieee80211_is_data_qos(hdr->frame_control)) {
Stanislaw Gruszka 2012-02-13 2793 qc = ieee80211_get_qos_ctl(hdr);
Stanislaw Gruszka 2012-02-13 2794 tid = qc[0] & 0xf;
Is "txq->sched_retry"
Stanislaw Gruszka 2012-02-13 2795 }
Stanislaw Gruszka 2012-02-13 2796
Stanislaw Gruszka 2012-02-13 2797 sta_id = il4965_get_ra_sta_id(il, hdr);
Stanislaw Gruszka 2012-02-13 2798 if (txq->sched_retry && unlikely(sta_id == IL_INVALID_STATION)) {
Stanislaw Gruszka 2012-02-13 2799 IL_ERR("Station not known\n");
Stanislaw Gruszka 2012-02-13 2800 return;
Stanislaw Gruszka 2012-02-13 2801 }
Stanislaw Gruszka 2012-02-13 2802
Stanislaw Gruszka 2013-06-12 2803 /*
Stanislaw Gruszka 2013-06-12 2804 * Firmware will not transmit frame on passive channel, if it not yet
Stanislaw Gruszka 2013-06-12 2805 * received some valid frame on that channel. When this error happen
Stanislaw Gruszka 2013-06-12 2806 * we have to wait until firmware will unblock itself i.e. when we
Stanislaw Gruszka 2013-06-12 2807 * note received beacon or other frame. We unblock queues in
Stanislaw Gruszka 2013-06-12 2808 * il4965_pass_packet_to_mac80211 or in il_mac_bss_info_changed.
Stanislaw Gruszka 2013-06-12 2809 */
Stanislaw Gruszka 2013-06-12 2810 if (unlikely((status & TX_STATUS_MSK) == TX_STATUS_FAIL_PASSIVE_NO_RX) &&
Stanislaw Gruszka 2013-06-12 2811 il->iw_mode == NL80211_IFTYPE_STATION) {
Stanislaw Gruszka 2013-06-12 2812 il_stop_queues_by_reason(il, IL_STOP_REASON_PASSIVE);
Stanislaw Gruszka 2013-06-12 2813 D_INFO("Stopped queues - RX waiting on passive channel\n");
Stanislaw Gruszka 2013-06-12 2814 }
Stanislaw Gruszka 2013-06-12 2815
Stanislaw Gruszka 2012-02-13 2816 spin_lock_irqsave(&il->sta_lock, flags);
Stanislaw Gruszka 2012-02-13 2817 if (txq->sched_retry) {
Stanislaw Gruszka 2012-02-13 2818 const u32 scd_ssn = il4965_get_scd_ssn(tx_resp);
Stanislaw Gruszka 2012-02-13 2819 struct il_ht_agg *agg = NULL;
Stanislaw Gruszka 2012-02-13 2820 WARN_ON(!qc);
Stanislaw Gruszka 2012-02-13 2821
Stanislaw Gruszka 2012-02-13 @2822 agg = &il->stations[sta_id].tid[tid].agg;
^^^
Stanislaw Gruszka 2012-02-13 2823
Stanislaw Gruszka 2012-02-13 2824 il4965_tx_status_reply_tx(il, agg, tx_resp, txq_id, idx);
Stanislaw Gruszka 2012-02-13 2825
Stanislaw Gruszka 2012-02-13 2826 /* check if BAR is needed */
Stanislaw Gruszka 2012-02-13 2827 if (tx_resp->frame_count == 1 &&
Stanislaw Gruszka 2012-02-13 2828 !il4965_is_tx_success(status))
Stanislaw Gruszka 2012-02-13 2829 info->flags |= IEEE80211_TX_STAT_AMPDU_NO_BACK;
Stanislaw Gruszka 2012-02-13 2830
Stanislaw Gruszka 2012-02-13 2831 if (txq->q.read_ptr != (scd_ssn & 0xff)) {
Stanislaw Gruszka 2012-02-13 2832 idx = il_queue_dec_wrap(scd_ssn & 0xff, txq->q.n_bd);
Stanislaw Gruszka 2012-02-13 2833 D_TX_REPLY("Retry scheduler reclaim scd_ssn "
Stanislaw Gruszka 2012-02-13 2834 "%d idx %d\n", scd_ssn, idx);
Stanislaw Gruszka 2012-02-13 2835 freed = il4965_tx_queue_reclaim(il, txq_id, idx);
Stanislaw Gruszka 2012-02-13 2836 if (qc)
Stanislaw Gruszka 2012-02-13 2837 il4965_free_tfds_in_queue(il, sta_id, tid,
Stanislaw Gruszka 2012-02-13 2838 freed);
Stanislaw Gruszka 2012-02-13 2839
Stanislaw Gruszka 2012-02-13 2840 if (il->mac80211_registered &&
Stanislaw Gruszka 2012-02-13 2841 il_queue_space(&txq->q) > txq->q.low_mark &&
Stanislaw Gruszka 2012-02-13 2842 agg->state != IL_EMPTYING_HW_QUEUE_DELBA)
Stanislaw Gruszka 2012-02-13 2843 il_wake_queue(il, txq);
Stanislaw Gruszka 2012-02-13 2844 }
Stanislaw Gruszka 2012-02-13 2845 } else {
Stanislaw Gruszka 2012-02-13 2846 info->status.rates[0].count = tx_resp->failure_frame + 1;
Stanislaw Gruszka 2012-02-13 2847 info->flags |= il4965_tx_status_to_mac80211(status);
Stanislaw Gruszka 2012-02-13 2848 il4965_hwrate_to_tx_control(il,
Stanislaw Gruszka 2012-02-13 2849 le32_to_cpu(tx_resp->rate_n_flags),
Stanislaw Gruszka 2012-02-13 2850 info);
Stanislaw Gruszka 2012-02-13 2851
Stanislaw Gruszka 2012-02-13 2852 D_TX_REPLY("TXQ %d status %s (0x%08x) "
Stanislaw Gruszka 2012-02-13 2853 "rate_n_flags 0x%x retries %d\n", txq_id,
Stanislaw Gruszka 2012-02-13 2854 il4965_get_tx_fail_reason(status), status,
Stanislaw Gruszka 2012-02-13 2855 le32_to_cpu(tx_resp->rate_n_flags),
Stanislaw Gruszka 2012-02-13 2856 tx_resp->failure_frame);
Stanislaw Gruszka 2012-02-13 2857
Stanislaw Gruszka 2012-02-13 2858 freed = il4965_tx_queue_reclaim(il, txq_id, idx);
Stanislaw Gruszka 2012-02-13 2859 if (qc && likely(sta_id != IL_INVALID_STATION))
Stanislaw Gruszka 2012-02-13 2860 il4965_free_tfds_in_queue(il, sta_id, tid, freed);
Stanislaw Gruszka 2012-02-13 2861 else if (sta_id == IL_INVALID_STATION)
Stanislaw Gruszka 2012-02-13 2862 D_TX_REPLY("Station not known\n");
Stanislaw Gruszka 2012-02-13 2863
Stanislaw Gruszka 2012-02-13 2864 if (il->mac80211_registered &&
Stanislaw Gruszka 2012-02-13 2865 il_queue_space(&txq->q) > txq->q.low_mark)
Stanislaw Gruszka 2012-02-13 2866 il_wake_queue(il, txq);
Stanislaw Gruszka 2012-02-13 2867 }
Stanislaw Gruszka 2012-02-13 2868 if (qc && likely(sta_id != IL_INVALID_STATION))
Stanislaw Gruszka 2012-02-13 2869 il4965_txq_check_empty(il, sta_id, tid, txq_id);
Stanislaw Gruszka 2012-02-13 2870
Stanislaw Gruszka 2012-02-13 2871 il4965_check_abort_status(il, tx_resp->frame_count, status);
Stanislaw Gruszka 2012-02-13 2872
Stanislaw Gruszka 2012-02-13 2873 spin_unlock_irqrestore(&il->sta_lock, flags);
Stanislaw Gruszka 2012-02-13 2874 }
Stanislaw Gruszka 2012-02-13 2875
by commit
iwlegacy: gather all 4965 handlers in one place
br> ;
list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
ng>

Next message: Paul Kocialkowski: "Re: [PATCH 1/2] of: device: Allow DMA range map to be set before of_dma_configure_id"
Previous message: Auger Eric: "Re: [PATCH RFC v1 00/15] iommu/virtio: Nested stage support with Arm"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]