Re: [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes

From: Simon Ser
Date: Tue Jan 19 2021 - 05:39:47 EST

On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul <lyude@xxxxxxxxxx> wrote:

> Nvidia hardware doesn't actually support using tiling formats with the
> cursor plane, only linear is allowed. In the future, we should write a
> testcase for this.
> Fixes: c586f30bf74c ("drm/nouveau/kms: Add format mod prop to base/ovly/nvdisp")
> Cc: James Jones <jajones@xxxxxxxxxx>
> Cc: Martin Peres <martin.peres@xxxxxxx>
> Cc: Jeremy Cline <jcline@xxxxxxxxxx>
> Cc: Simon Ser <contact@xxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v5.8+
> Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>

Together with [1], this patch allows me to run unpatched modifier-aware
user-space successfully, without a cursor visual glitch. drm_info
correctly reports the new modifier list, and wlroots logs confirm that
a flavor of NVIDIA_BLOCK_LINEAR_2D is used for the primary buffers and
LINEAR is used for cursor buffers.

Code looks good to me as well.

Reviewed-by: Simon Ser <contact@xxxxxxxxxxx>