Re: [PATCH] arm64/cpuinfo: Show right CPU architecture information

From: 乱石
Date: Tue Jan 19 2021 - 06:39:49 EST


在 2021/1/19 19:01, Will Deacon 写道:
On Tue, Jan 19, 2021 at 06:55:10PM +0800, Liguang Zhang wrote:
CPU architecture is assigned to be a fixed value, it should be obtained
from midr register.

Signed-off-by: Liguang Zhang <zhangliguang@xxxxxxxxxxxxxxxxx>
---
arch/arm64/kernel/cpuinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
index 77605aec25fe..0bd11e0fe9f2 100644
--- a/arch/arm64/kernel/cpuinfo.c
+++ b/arch/arm64/kernel/cpuinfo.c
@@ -191,7 +191,7 @@ static int c_show(struct seq_file *m, void *v)
seq_printf(m, "CPU implementer\t: 0x%02x\n",
MIDR_IMPLEMENTOR(midr));
- seq_printf(m, "CPU architecture: 8\n");
+ seq_printf(m, "CPU architecture: %d\n", MIDR_ARCHITECTURE(midr));
Huh? Won't this always return 0xf?

Hi Will,

I'm not sure. My platform return 0xf, but /proc/cpuinfo show 8. Why we assign a fixed

value to cpu architecture?

Regards

Liguang Zhang


Will