Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver
From: Laurent Pinchart
Date: Tue Jan 19 2021 - 11:52:19 EST
On Tue, Jan 19, 2021 at 11:35:42AM +0200, Andy Shevchenko wrote:
> On Tue, Jan 19, 2021 at 08:21:23AM +0200, Laurent Pinchart wrote:
> > On Tue, Jan 19, 2021 at 12:11:40AM +0000, Daniel Scally wrote:
> > > On 18/01/2021 21:19, Daniel Scally wrote:
> > > (also, Laurent, if we did it this way we wouldn't be able to also handle
> > > the led-indicator GPIO here without some fairly major rework)
> > Given the additional complexity I don't think it's worth it, your
> > implementation is fine and code duplication with clk-gpio is minimal.
> Making clk-gpio.c available as a library is a win in long term and reduces a
> possible duplication by others in the future. I bet we even might find already
> clk-gpio parts in some drivers.
How about you submit a patch on top then ? :-) Let's avoid yak shaving.