Re: [PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver

[Alexandre Belloni]

On 19/01/2021 21:37:16+0100, Alexandre Belloni wrote:
> On 14/01/2021 17:24:31+0100, Steen Hegelund wrote:
> > +static int sparx5_switch_reset(struct reset_controller_dev *rcdev,
> > +			       unsigned long id)
> > +{
> > +	struct mchp_reset_context *ctx =
> > +		container_of(rcdev, struct mchp_reset_context, rcdev);
> > +	u32 val;
> > +
> 
> I would ensure the reset only happens once here else I'm not sure how
> you could do it from the individual drivers.
> 

Ok, the core is taking care of that, nice.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com