Re: [PATCH 2/2] usb typec: tcpci: mt6360: Add vbus supply into dt-binding description

[ChiYuan Huang]

Rob Herring <robh@xxxxxxxxxx> 於 2021年1月20日 週三 上午7:11寫道：
>
> On Fri, Jan 15, 2021 at 10:13:21PM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> >
> > Add external vbus source into dt-binding description.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> > index 1e8e1c2..b8d842b 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> > @@ -26,6 +26,11 @@ properties:
> >      items:
> >        - const: PD_IRQB
> >
> > +  vbus-supply:
> > +    description:
> > +      Vbus source supply regulator.
> > +    maxItems: 1
>
> vbus-supply is already in the 'connector' node, you don't need it here.
>
If not put here, 'regulator_get' only can follow the legacy way to get
vbus regulator.
Currently, there's no one to use the 'vbus-supply' property.
>From my understanding, the 'vbus-supply' is the chip level property,
not connector type property.

> > +
> >    connector:
> >      type: object
> >      $ref: ../connector/usb-connector.yaml#
> > @@ -38,6 +43,7 @@ required:
> >    - compatible
> >    - interrupts
> >    - interrupt-names
> > +  - vbus-supply
> >
> >  examples:
> >    - |
> > @@ -54,6 +60,7 @@ examples:
> >            compatible = "mediatek,mt6360-tcpc";
> >            interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
> >            interrupt-names = "PD_IRQB";
> > +          vbus-supply = <&otg_vbus>;
> >
> >            connector {
> >              compatible = "usb-c-connector";
> > --
> > 2.7.4
> >