Re: [RFC PATCH 00/37] block: introduce bio_init_fields()
From: Chaitanya Kulkarni
Date: Tue Jan 19 2021 - 22:30:38 EST
On 1/18/21 21:06, Chaitanya Kulkarni wrote:
> This is a *compile only RFC* which adds a generic helper to initialize
> the various fields of the bio that is repeated all the places in
> file-systems, block layer, and drivers.
> The new helper allows callers to initialize various members such as
> bdev, sector, private, end io callback, io priority, and write hints.
> The objective of this RFC is to only start a discussion, this it not
> completely tested at all.
> Following diff shows code level benefits of this helper :-
> 38 files changed, 124 insertions(+), 236 deletions(-)
Thanks for replying Mike, Josef and Christoph.
I'll move forward with Christoph's suggestion and get rid of
optional parameters which is making this API hard to use.